ItsDrike/dotfiles
1
0
Fork 0
mirror of https://github.com/ItsDrike/dotfiles.git synced 2024-11-12 19:27:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly handle 'All caught up!' output from gh-notify

Browse source
This commit is contained in:
ItsDrike 2023-01-25 12:50:30 +01:00
parent ed1487a251
commit f8f96d4dd7
No known key found for this signature in database
GPG key ID: B014E761034AF742
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
home/.local/bin/scripts/gui/gh-notification
View file

@ -190,6 +190,12 @@ send_notify() {
# Request unread notifications with gh-notify extension for github-cli # Request unread notifications with gh-notify extension for github-cli
[ "$ALL" -eq 1 ] && out="$(gh notify -s -a -n "$MAX_AMOUNT")" || out="$(gh notify -s -n "$MAX_AMOUNT")" [ "$ALL" -eq 1 ] && out="$(gh notify -s -a -n "$MAX_AMOUNT")" || out="$(gh notify -s -n "$MAX_AMOUNT")"
# When no notifications were found, set output to empty string, to avoid 'All caught up!' line
# being treated as notification
if [ "$out" == "All caught up!" ]; then
out=""
fi
total="$(printf "%s\n" "$out" | wc -l)" total="$(printf "%s\n" "$out" | wc -l)"
# Since we always end with a newline (to count the last entry as a line), we always get # Since we always end with a newline (to count the last entry as a line), we always get
# at least 1 as a total here, even if $out is empty. If we didn't use the \n, we'd always # at least 1 as a total here, even if $out is empty. If we didn't use the \n, we'd always