From b444f031857befd8c94e75a653bca7d3119e1db8 Mon Sep 17 00:00:00 2001
From: ItsDrike <itsdrike@protonmail.com>
Date: Sat, 14 May 2022 22:26:04 +0200
Subject: [PATCH] Don't use scratchpad to pass values into partials We
 previously used .Scratch which is a global scratchpad, that was later passed
 over to the partial with the rest of the context. The partial then checked if
 this value was set, and had a fallback if it wasn't (default value).

This approach does work in most of the cases, however in about 5% of
runs, it fails. I assume this is due to hugo spinning up multiple
threads, and each of them is changing this global scratchpad in
arbitrary order. At some point, a thread then removed this value from
the scratchpad to reset it, but another thread already checked that this
variable does exist, and has now set the no longer available variable.

To avoid this, we can instead directly pass a custom dict, which
contains the original context (.) along with another variable, which
will hold the dateformat. This however means that we can't use the
simple syntax with a default value, and the dateformat will need to be
set each time (though technically, it could be set to nil and checked
later, but if we're already specifying it, we may as well pass in this
dateformat directly)
---
 layouts/_default/list.html      |  2 +-
 layouts/partials/list_item.html | 24 +++++++++++-------------
 layouts/posts/list.html         |  3 +--
 3 files changed, 13 insertions(+), 16 deletions(-)

diff --git a/layouts/_default/list.html b/layouts/_default/list.html
index 9f27127..741ce83 100644
--- a/layouts/_default/list.html
+++ b/layouts/_default/list.html
@@ -11,7 +11,7 @@
                 <ul class="item-list-items">
                     {{ range .Pages.ByTitle }}
                     <li class="item-list-item" data-id="{{ with .File}}{{ .File.UniqueID }}{{ end }}">
-                        {{ partial "list_item.html" . }}
+                        {{ partial "list_item.html" (dict "context" . "dateformat" "Jan 02, 2006") }}
                     </li>
                     {{ end }}
                 </ul>
diff --git a/layouts/partials/list_item.html b/layouts/partials/list_item.html
index 1d1a2ca..3d86270 100644
--- a/layouts/partials/list_item.html
+++ b/layouts/partials/list_item.html
@@ -1,18 +1,16 @@
-<!-- Obtain "dateformat" from scratchpad (or fall back to default) -->
-{{ if not (.Scratch.Get "dateformat") }}
-{{ .Scratch.Set "dateformat" "Jan 02, 2006" }}
-{{ end }}
-{{ $dateformat := .Scratch.Get "dateformat" }}
-<!-- Reset scratchpad for next use (in next page) - avoids using old values -->
-{{ .Scratch.Set "dateformat" nil }}
+<!-- 
+Note: This partial is expected to be called with special syntax of:
+partial "list_item.html" (dict "context" . "dateformat" "Jan 02, 2006")
 
+This allows it to take "dateformat" as a variable, so it can differ between calls.
+-->
 
-<a class="item-name" href="{{ .RelPermalink }}">
-    <span class="item-title">{{ .Title }}</span>
-    {{ if not .Date.IsZero }}
-    <span class="item-day">{{ .Date.Format $dateformat }}</span>
+<a class="item-name" href="{{ .context.RelPermalink }}">
+    <span class="item-title">{{ .context.Title }}</span>
+    {{ if not .context.Date.IsZero }}
+    <span class="item-day">{{ .context.Date.Format .dateformat }}</span>
     {{ end }}
 </a>
-<small class="item-details">{{ partial "content-details.html" . }}</small>
+<small class="item-details">{{ partial "content-details.html" .context }}</small>
 <!-- TODO: Only show summary on hover? -->
-<p class="item-summary">{{ partial "summary.html" . }}</p>
+<p class="item-summary">{{ partial "summary.html" .context }}</p>
diff --git a/layouts/posts/list.html b/layouts/posts/list.html
index c048b0d..ae48a4f 100644
--- a/layouts/posts/list.html
+++ b/layouts/posts/list.html
@@ -26,8 +26,7 @@
                 <ul class="item-list-items">
                     {{ range .Pages }}
                     <li class="item-list-item" data-id="{{ with .File}}{{ .File.UniqueID }}{{ end }}">
-                        {{ .Scratch.Set "dateformat" "Jan 02" }}
-                        {{ partial "list_item.html" . }}
+                        {{ partial "list_item.html" (dict "context" . "dateformat" "Jan 02") }}
                     </li>
                     {{ end }}
                 </ul>