From 46f5fa83e8e1fcfd19211f8d7e2224a867ced2f4 Mon Sep 17 00:00:00 2001
From: ItsDrike <itsdrike@protonmail.com>
Date: Thu, 27 Jun 2024 19:17:44 +0200
Subject: [PATCH] python: fix history location & persist history

---
 home/programs/xdg/config-files.nix | 48 +++++++++++++++---------------
 hosts/voyager/default.nix          |  1 +
 2 files changed, 25 insertions(+), 24 deletions(-)

diff --git a/home/programs/xdg/config-files.nix b/home/programs/xdg/config-files.nix
index b16ce44..18c1abf 100644
--- a/home/programs/xdg/config-files.nix
+++ b/home/programs/xdg/config-files.nix
@@ -57,34 +57,34 @@ in {
     '';
 
     "python/pythonrc.py".text = ''
-      import atexit
-      import os
-      import readline
-      from functools import partial
-      from pathlib import Path
-      from types import ModuleType
-
-      cache_xdg_dir = Path(
-          os.environ.get("XDG_CACHE_HOME", str(Path("~/.cache").expanduser()))
-      )
-      cache_xdg_dir.mkdir(exist_ok=True, parents=True)
-
-      history_file = cache_xdg_dir.joinpath("python_history")
-      history_file.touch()
-
-      readline.read_history_file(history_file)
+      def is_vanilla() -> bool:
+          import sys
+          return not hasattr(__builtins__, '__IPYTHON__') and 'bpython' not in sys.argv[0]
 
 
-      def write_history(readline: ModuleType, history_file: Path) -> None:
-          """
-          We need to get ``readline`` and ``history_file`` as arguments, as it
-          seems they get garbage collected when the function is registered and
-          the program ends, even though we refer to them here.
-          """
-          readline.write_history_file(history_file)
+      def setup_history():
+          import os
+          import atexit
+          import readline
+          from pathlib import Path
+
+          if state_home := os.environ.get('XDG_STATE_HOME'):
+              state_home = Path(state_home)
+          else:
+              state_home = Path.home() / '.local' / 'state'
+
+          history: Path = state_home / 'python_history'
+
+          # https://github.com/python/cpython/issues/105694
+          if not history.is_file():
+            readline.write_history_file(str(history)) # breaks on macos + python3 without this. 
+
+          readline.read_history_file(str(history))
+          atexit.register(readline.write_history_file, str(history))
 
 
-      atexit.register(partial(write_history, readline, history_file))
+      if is_vanilla():
+          setup_history()
     '';
   };
 
diff --git a/hosts/voyager/default.nix b/hosts/voyager/default.nix
index 65f1f3b..be7a456 100644
--- a/hosts/voyager/default.nix
+++ b/hosts/voyager/default.nix
@@ -87,6 +87,7 @@
             ".cache/walker/history.gob"
             ".config/pcmanfm-qt/default/recent-files.conf"
             ".config/qalculate/qalculate-gtk.cfg"
+            ".local/state/python_history"
           ];
 
           persistentDataMountPoint = "/data/Data";