From 72d1fe4ce2926ef3fbcc4cd168eb7a7415b1e7b0 Mon Sep 17 00:00:00 2001 From: ItsDrike Date: Sat, 13 Jul 2024 13:37:38 +0200 Subject: [PATCH 1/2] github-workflow: don't run slotscheck (not installed) --- .github/workflows/validation.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/validation.yml b/.github/workflows/validation.yml index 94291b8..6d09287 100644 --- a/.github/workflows/validation.yml +++ b/.github/workflows/validation.yml @@ -33,7 +33,7 @@ jobs: restore-keys: "precommit-${{ runner.os }}-${{ steps.poetry_setup.outputs-python-version}}-" - name: Run pre-commit hooks - run: SKIP=ruff-linter,ruff-formatter,slotscheck,basedpyright pre-commit run --all-files + run: SKIP=ruff-linter,ruff-formatter,basedpyright pre-commit run --all-files - name: Run ruff linter run: ruff check --output-format=github --show-fixes --exit-non-zero-on-fix . @@ -41,8 +41,5 @@ jobs: - name: Run ruff formatter run: ruff format --diff . - - name: Run slotscheck - run: slotscheck -m mcproto - - name: Run basedpyright type checker run: basedpyright --warnings . From 9922734472f2d624d2e26f7c3c9c2d55fc35dff2 Mon Sep 17 00:00:00 2001 From: ItsDrike Date: Sat, 13 Jul 2024 13:38:29 +0200 Subject: [PATCH 2/2] coverage: Disable fail_under (code-base specific) --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index f199598..cbdeb7a 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -170,7 +170,7 @@ addopts = "--strict-markers --cov --no-cov-on-fail" [tool.coverage.report] precision = 2 -fail_under = 20 +fail_under = 0 show_missing = true skip_covered = false skip_empty = false